Skip to content

[PM-40962] Enhance Renovate configuration for package grouping - #1192

Merged
JaredScar merged 1 commit into
mainfrom
BEEEP/renovate-updates-for-better-grouping-for-directory-connector-automation
Jul 29, 2026
Merged

[PM-40962] Enhance Renovate configuration for package grouping#1192
JaredScar merged 1 commit into
mainfrom
BEEEP/renovate-updates-for-better-grouping-for-directory-connector-automation

Conversation

@JaredScar

@JaredScar JaredScar commented Jul 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Added new groupings for Angular packages, Microsoft Graph packages, ESLint plugins for RxJS, Jest monorepo, Webpack, Electron Builder, and various type definitions to streamline dependency updates.

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-40962

📔 Objective

Group up dependencies better via Renovate for Directory Connector project

@JaredScar
[deps]: Enhance Renovate configuration for package grouping
49b040f 
Added new groupings for Angular packages, Microsoft Graph packages, ESLint plugins for RxJS, Jest monorepo, Webpack, Electron Builder, and various type definitions to streamline dependency updates.
@JaredScar JaredScar added ai-review Request a Claude code review t:tech-debt Change Type - Tech debt labels Jul 22, 2026
@github-actions

github-actions Bot commented Jul 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed the Renovate configuration change in .github/renovate.json5, which adds nine new packageRules grouping entries (Angular, Microsoft Graph, RxJS ESLint plugins, Jest monorepo, Webpack, Electron Builder, and three @types/runtime companions). This is a config-only change with no dependency version bumps, no lock file changes, and no source code changes. Every package name referenced in the new rules was verified against package.json — all correspond to real, currently declared dependencies, the glob patterns (@angular/**, @angular-eslint/**) are valid Renovate matchPackageNames syntax, and each grouping carries a clear inline justification. No security, correctness, or breaking-change concerns identified.

Code Review Details

No findings.

The JSON5 remains valid and the existing ignoreDeps entries (@yao-pkg/pkg, googleapis) are preserved unchanged. Reusing the shared jest monorepo groupName is intentional and documented.

@JaredScar
JaredScar marked this pull request as ready for review July 23, 2026 17:53
@JaredScar
JaredScar requested a review from a team as a code owner July 23, 2026 17:53
@JaredScar
JaredScar requested a review from jrmccannon July 23, 2026 17:53
@codecov

codecov Bot commented Jul 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (d625ab6) to head (49b040f).

Additional details and impacted files 
@@     Coverage Diff      @@
##   main   #1192   +/-   ##
============================
============================

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JaredScar JaredScar changed the title [deps]: Enhance Renovate configuration for package grouping [PM-40962] Enhance Renovate configuration for package grouping Jul 25, 2026
@JaredScar
JaredScar merged commit b490949 into main Jul 29, 2026
22 of 27 checks passed
@JaredScar
JaredScar deleted the BEEEP/renovate-updates-for-better-grouping-for-directory-connector-automation branch July 29, 2026 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jrmccannon jrmccannon jrmccannon approved these changes

Assignees

No one assigned

Labels

ai-review Request a Claude code review t:tech-debt Change Type - Tech debt

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JaredScar @jrmccannon